Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvncserver: 0.9.11 -> 0.9.12 #74514

Merged
merged 1 commit into from Nov 29, 2019
Merged

libvncserver: 0.9.11 -> 0.9.12 #74514

merged 1 commit into from Nov 29, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 28, 2019

Motivation for this change

Vuln roundup #73664 -- unstable channel

Version bump from 0.9.11 to 0.9.12 fixes:

Upstream changelog is at https://github.com/LibVNC/libvncserver/releases/tag/LibVNCServer-0.9.12

Plus add two upstream patches to fix:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

Result of nix-review 1

1 package failed to build:
  • blink (virt-manager-qt)
10 package were build:
  • aqemu (virt-manager-qt)
  • gnome3.gnome-control-center (virt-manager-qt)
  • gnome3.gnome-remote-desktop (virt-manager-qt)
  • kdeApplications.krdc (virt-manager-qt)
  • kdeApplications.krfb (virt-manager-qt)
  • libvncserver (virt-manager-qt)
  • remmina (virt-manager-qt)
  • virtmanager-qt (virt-manager-qt)
  • virtscreen (virt-manager-qt)
  • x11vnc (virt-manager-qt)

blink is already failing on Hydra, because of python27Packages.python-otr

builder for '/nix/store/gwl3yipahap9gxxdbcgf3l8s8f3zmmr2-python2.7-python-otr-1.2.0.drv' failed with exit code 1; last 10 log lines:
      from zope.interface import Interface, implements
  ImportError: No module named zope.interface
  
  
  ----------------------------------------------------------------------
  Ran 1 test in 0.000s
  
  FAILED (errors=1)
  Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
cannot build derivation '/nix/store/a8qry41l7m42bqfsqm132wv8srnvbzkq-python2.7-sipsimple-3.4.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sdbwy0dycbaw4vayj2x19s2d1zxg4yvg-blink-3.2.0.drv': 1 dependencies couldn't be built

@c0bw3b
libvncserver: 0.9.11 -> 0.9.12
0842758 
Vuln roundup NixOS#73664 -- unstable channel

Version bump from 0.9.11 to 0.9.12 fixes:
* CVE-2018-6307
* CVE-2018-15126
* CVE-2018-15127
* CVE-2018-20019
* CVE-2018-20020
* CVE-2018-20021
* CVE-2018-20022
* CVE-2018-20023
* CVE-2018-20024
* CVE-2018-20748
* CVE-2018-20749

Plus add two upstream patches to fix:
* CVE-2018-20750
* CVE-2019-15681
@c0bw3b c0bw3b added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 28, 2019
@ofborg ofborg bot requested a review from 7c6f434c November 28, 2019 17:36
@ckauhaus
Copy link
Contributor

Filed bug against python-otr: #74619

@c0bw3b c0bw3b merged commit 3fb4e09 into NixOS:master Nov 29, 2019
@c0bw3b c0bw3b deleted the sec/libvncserver branch November 29, 2019 18:14
c0bw3b added a commit that referenced this pull request Nov 29, 2019
@c0bw3b
libvncserver: 0.9.11 -> 0.9.12
b333ca4 
Backport of #74514

Vuln roundup: close #73664 -- r19.09 channel

Version bump from 0.9.11 to 0.9.12 fixes:
* CVE-2018-6307
* CVE-2018-15126
* CVE-2018-15127
* CVE-2018-20019
* CVE-2018-20020
* CVE-2018-20021
* CVE-2018-20022
* CVE-2018-20023
* CVE-2018-20024
* CVE-2018-20748
* CVE-2018-20749

Plus add two upstream patches to fix:
* CVE-2018-20750
* CVE-2019-15681

(cherry picked from commit 3fb4e09)
c0bw3b added a commit that referenced this pull request Nov 29, 2019
@c0bw3b
libvncserver: 0.9.11 -> 0.9.12
3ead845 
(#74514)

Vuln roundup #73664 -- r19.03 channel

Version bump from 0.9.11 to 0.9.12 fixes:
* CVE-2018-6307
* CVE-2018-15126
* CVE-2018-15127
* CVE-2018-20019
* CVE-2018-20020
* CVE-2018-20021
* CVE-2018-20022
* CVE-2018-20023
* CVE-2018-20024
* CVE-2018-20748
* CVE-2018-20749

Plus add two upstream patches to fix:
* CVE-2018-20750
* CVE-2019-15681

(cherry picked from commit 3fb4e09)
@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 2, 2019
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @ckauhaus @TredwellGit