e2fsprogs: allow static build #74485
Conversation
| @@ -36,7 +36,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| configureFlags = | |||
| if stdenv.isLinux then [ | |||
| "--enable-elf-shlibs" | |||
| (if shared then "--enable-elf-shlibs" else "--disable-elf-shlibs") | |||
There was a problem hiding this comment.
Can you indicate with a comment whether e2fsprogs is one of the (few) problems where one can only build static XOR dynamic?
ofborg
bot
added
10.rebuild-darwin: 0
malbarbo
force-pushed
the
e2fsprogs-shared
branch
from
2140473 to
f6ea330
Compare
|
|
Backport of NixOS#74485. Fixes NixOS#71813. (cherry picked from commit f6ea330)
|
If we want a backport to 19.09, I've resolved the merge-conflicts here: |
|
|
||
| # Don’t use new stdenv zlib because | ||
| # it doesn’t like the --disable-shared flag | ||
| stdenv = super.stdenv; | ||
| }).static; |
There was a problem hiding this comment.
I just learned that this change accidentally also fixed more severe issues (nh2/static-haskell-nix#73):
nix-shell -p 'pkgsStatic.zlib.override {}' did not work until this commit, it errored:
error: attribute 'override' missing, at (string):1:94
FYI @malbarbo @dtzWill @matthewbauer
It appears that we must never use .static or other split outputs in things like static.nix because they are not overridable. (copied from nh2/static-haskell-nix#73 (comment))
Also interesting is that pkgsStatic.zlib has nonsensical attributes like cmakeFlags (even though it does not use cmake) from here in the make-derivation.nix case of lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform): https://github.com/nh2/nixpkgs/blob/11aa987ea5b5a593c9ca7a38b391804959f905e5/pkgs/stdenv/generic/make-derivation.nix#L245-L254
Motivation for this change
This enable building
pkgsStatic.e2fsprogs.The zlib changes is to avoid the error
which makes sense because
zlib.staticdoes not include headers.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @edolstra (listed as e2fsprogs mantainer)
cc @nh2 @matthewbauer (involved in static build of zlib)