Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: add option to use wolfssl backend #74484

Merged
merged 1 commit into from Dec 10, 2019
Merged

curl: add option to use wolfssl backend #74484

merged 1 commit into from Dec 10, 2019

Conversation

malbarbo
Copy link
Contributor

Motivation for this change

Allow smaller closure by using wolfssl backend.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@ofborg ofborg bot requested a review from lovek323 November 28, 2019 13:15
@andir
Copy link
Member

andir commented Nov 28, 2019

This should be targeted at the staging branch

andir
andir reviewed Nov 28, 2019
View reviewed changes
pkgs/tools/networking/curl/default.nix Outdated
"--disable-manual"
( if sslSupport || gnutlsSupport then "--with-ca-fallback" else "--without-ca-fallback")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also apply for the wolfssl backend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that wolfssl does not build with --with-ca-fallback, so we only pass --with-ca-fallback for openssl and gnutls.

@malbarbo malbarbo changed the base branch from master to staging November 28, 2019 13:39
@FRidh FRidh added this to Needs review in Staging Nov 30, 2019
@malbarbo
Copy link
Contributor Author

malbarbo commented Dec 5, 2019

Added a comment about ca fallback and try to avoid mass rebuild.

@malbarbo malbarbo changed the base branch from staging to master December 5, 2019 15:26
@malbarbo
Copy link
Contributor Author

malbarbo commented Dec 5, 2019

Rebuild is not needed anymore. @lovek323 can you take a look?

@FRidh FRidh removed this from Needs review in Staging Dec 10, 2019
@FRidh FRidh merged commit b2b2330 into NixOS:master Dec 10, 2019
@malbarbo malbarbo deleted the curl-wolfssl branch June 18, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malbarbo @andir @FRidh