[WIP] macOS travis builds + sigining and notarizing #517

vespakoen · 2019-11-28T13:04:45Z

Added macOS build for travis, tried it out on my own fork so some settings will have to be restored, also some secrets will have to be added to the travis build.

Travis Environment variables:

MACOS_APPSTORE_USERNAME - The Apple ID email adress
MACOS_APPSTORE_APP_PASSWORD - And "App Specific Password". See How to manage app-specific passwords on https://support.apple.com/en-us/HT204397
MACOS_CERTIFICATE_P12 - A base64 encoded .p12 certificate (export from "Developer ID Application: Your Name" using Keychain Assistant, e.g.: cat cert.p12 | base64 | pbcopy)
MACOS_CERTIFICATE_PASSWORD - The password used during exporting of the .p12 file
MACOS_DEVELOPER_ID - See image, make sure to wrap it in quotes!

Will merge all commits into a single one once I have verified it it working well.

whitequark · 2019-11-28T13:08:44Z

@jwesthues Do you have a macOS signing certificate? If not, it effectively costs $100/year. Since macOS Catalina, unsigned applications will not run by default, although it isn't entirely clear to me right now how burdensome it is to run them anyway--I don't have anything that runs Catalina. I assume Apple plans to make it increasingly burdensome in the future, anyway.

vespakoen · 2019-11-28T13:11:57Z

Yes I do have a certificate and added it to the travis ci build on my fork. I am happy to share it with this project if you like, or produce the executables for this project. Whatever is easiest for you. This PR also does the notarizing / all the voodoo apple needs to be happy. I had to drop support for pre-mavericks though but could add a job for that as well if needed.

…

On Thu, 28 Nov 2019 at 14:08, whitequark ***@***.***> wrote: @jwesthues <https://github.com/jwesthues> Do you have a macOS signing certificate? If not, it effectively costs $100/year. Since macOS Catalina, unsigned applications will not run by default, although it isn't entirely clear to me right now how burdensome it is to run them anyway--I don't have anything that runs Catalina. I assume Apple plans to make it increasingly burdensome in the future, anyway. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#517?email_source=notifications&email_token=AAGV4VIAGFPP2O75JQAS2XDQV67F3A5CNFSM4JSUHSXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFMR2CQ#issuecomment-559488266>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGV4VPCCOYJWMPOG45D5R3QV67F3ANCNFSM4JSUHSXA> .

vespakoen · 2019-11-28T13:13:31Z

The first build just landed actually: https://github.com/vespakoen/solvespace/releases

Will have to test it on a computer that is not "infected" with my certificates to test it out properly though. Will do that later

vespakoen · 2019-11-28T13:14:16Z

https://travis-ci.org/vespakoen/solvespace/builds/618185752

whitequark · 2019-11-28T13:17:27Z

.travis/build-macos.sh

 make test_solvespace
+
+ls bin


Can you split this into a different file, e.g. .travis/sign-macos.sh?

Allright, will do!

whitequark · 2019-11-28T13:18:13Z

.travis/build-macos.sh

+codesign -s "${MACOS_DEVELOPER_ID}" --timestamp --options runtime -f "${dmg}"
+
+# notarize and store request uuid in variable
+notarize_uuid=$(xcrun altool --notarize-app --primary-bundle-id "${bundle_id}" --username "${MACOS_APPSTORE_USERNAME}" --password "${MACOS_APPSTORE_APP_PASSWORD}" --file "${dmg}" 2>&1 | grep RequestUUID | awk '{print $3'})


I'm a bit confused by this. Does XCode offer no way to block until notarization is finished?

You are correct =) There is no way to block indeed, a very anti-CI approach. The voodoo is necessary unfortunately...

vespakoen · 2019-11-28T14:02:17Z

Strangely the Travis builds on this PR seem to get built differently, I see colors where my build does not have that, and the build for this repository seems to stop half way during the copying of assets.

Cannot imagine this has to do with the missing secrets, so that it really strange... Perhaps there are some limitations on what travis builds when it's in a PR?

Anyways, I incorporated your suggestions...

vespakoen · 2019-11-28T14:14:12Z

Nevermind that last comment, now is seemed to get further, and actually seems to crash in the sign-macos.sh file, which is expected without the secrets.

Shall I hand my secrets over to you for the signing? Or shall I do the releases separately and deliver the .dmg's to you?

vespakoen · 2020-10-17T11:10:05Z

The latest master doesn't build correctly on macOS anymore.
I will git bisect it to see where it broke.

vespakoen · 2020-10-17T15:02:37Z

I am making a new PR in favor of this one. I got the build working again by simply moving these lines:

if(APPLE OR CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")
endif()

Higher up the CMakeLists.txt file, before:

include(GetGitCommitHash)

vespakoen added 17 commits November 28, 2019 09:28

Try macOS build with signing and notarizing

557b564

Try with xcode 10.1

e047012

Set minimum build target to 10.9

58056b2

Updating deploy key, added developer id secret

d9d24a7

Try to use 2 cores

44342ad

Update path to .app

417b9ba

Quote paths

931b1a9

Fix path again

0fea5b6

Fix path again

79bf04a

Add key-partition-list

d43d173

Try timeout method

16e386b

Try another

76f2019

Add a little delay

0a6a056

Deployyy

4589703

Try creating dmg

68ecc37

Tag during build

f81fd30

Update travis config

f2d248d

whitequark reviewed Nov 28, 2019

View reviewed changes

vespakoen added 2 commits November 28, 2019 14:50

Split up into build-macos and sign-macos

a8b2e20

Path fix

b19ca64

vespakoen mentioned this pull request Nov 28, 2019

Cannot open solvespace.dmg on OSX #398

Closed

whitequark force-pushed the master branch from 4c00bde to c876104 Compare June 14, 2020 05:14

phkahler mentioned this pull request Oct 16, 2020

The continuous integration is gone/broken #739

Closed

Merge branch 'master' into macos-travis

ef2b688

vespakoen closed this Oct 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] macOS travis builds + sigining and notarizing #517

[WIP] macOS travis builds + sigining and notarizing #517

vespakoen commented Nov 28, 2019

whitequark commented Nov 28, 2019

vespakoen commented Nov 28, 2019 via email

vespakoen commented Nov 28, 2019

vespakoen commented Nov 28, 2019

whitequark Nov 28, 2019

vespakoen Nov 28, 2019

whitequark Nov 28, 2019

vespakoen Nov 28, 2019

vespakoen commented Nov 28, 2019

vespakoen commented Nov 28, 2019

vespakoen commented Oct 17, 2020 •

edited

Loading

vespakoen commented Oct 17, 2020

[WIP] macOS travis builds + sigining and notarizing #517

[WIP] macOS travis builds + sigining and notarizing #517

Conversation

vespakoen commented Nov 28, 2019

whitequark commented Nov 28, 2019

vespakoen commented Nov 28, 2019 via email

vespakoen commented Nov 28, 2019

vespakoen commented Nov 28, 2019

whitequark Nov 28, 2019

Choose a reason for hiding this comment

vespakoen Nov 28, 2019

Choose a reason for hiding this comment

whitequark Nov 28, 2019

Choose a reason for hiding this comment

vespakoen Nov 28, 2019

Choose a reason for hiding this comment

vespakoen commented Nov 28, 2019

vespakoen commented Nov 28, 2019

vespakoen commented Oct 17, 2020 • edited Loading

vespakoen commented Oct 17, 2020

vespakoen commented Oct 17, 2020 •

edited

Loading