@Izorkin we should really upgrade mariadb to the 10.4 series for NixOS 20.09. Does that sound good to you?

@aanderse i did not use 10.4. Already released beta 10.5.1

If update to 10.4 need upgrade mariadb-galera to 26.4.3.

10.5 is still preview. Maybe we just wait until 10.5 is stable and update to that. Do you agree?

You can wait. Then I will add 10.5.1 to nur-packages, 10.4.12 is already there.

@aanderse Do you know the significance of the "General Availability" indication at https://downloads.mariadb.org/ ?

@ryantm I do not.

I have spent some more time thinking about this PR recently and propose the following:

• rebase and update this PR to mariadb 10.4.12, include any other dependencies updates like those @Izorkin described (see comment about mariadb-galera requirements) and then merge as soon as possible
• ship mariadb 10.4.x series with NixOS 20.09
• immediately after NixOS 20.09 is released update mariadb to 10.5.x in master
• ship mariadb 10.5.x series with NixOS 21.03

We should probably avoid skipping a major release of mariadb as we don't know what sort of consequences that might have for all of our users and the various configurations they may have.

Does this sound reasonable? ping @callahad @flokli @florianjacob @Izorkin @matthewbauer @ryantm @thefloweringash @thorstenweber83 as potentially interested parties.

This plan sounds good. I think we should only update to 10.5.x on master after it is out of "development".

Don't feel like this PR is special or something, feel free to close it and do the work on a different PR.

I asked about general availability on #maria@freenode and they seem to think it isn't significant.

Plan sounds very good, gradually getting up to speed while giving NixOS users bite-sized updates to digest.
I was bitten several times by old-but-supported mariadb series in NixOS in terms of features / bugs, and am very in favour of coordinated but steady upgrading.

If update to MariaDB 1.4 need update plugin MariaDB-Galera to 26.4.3.
https://mariadb.com/kb/en/upgrading-from-mariadb-103-to-mariadb-104-with-galera-cluster/

In version 10.4 and 10.5 not builded plugin auth_socket

In 10.4 and 10.5 don`t need auth_socket.so.
https://mariadb.com/kb/en/authentication-plugin-unix-socket/
MariaDB/server@83de75d?diff=split
Worked with this patch:

diff --git a/nixos/modules/services/databases/mysql.nix b/nixos/modules/services/databases/mysql.nix
index f9e657f5774..6bca8de2d71 100644
--- a/nixos/modules/services/databases/mysql.nix
+++ b/nixos/modules/services/databases/mysql.nix
@@ -87,7 +87,6 @@ in
             datadir = /var/lib/mysql
             bind-address = 127.0.0.1
             port = 3336
-            plugin-load-add = auth_socket.so

             !includedir /etc/mysql/conf.d/
           ''';
@@ -315,7 +314,6 @@ in
         datadir = cfg.dataDir;
         bind-address = mkIf (cfg.bind != null) cfg.bind;
         port = cfg.port;
-        plugin-load-add = optional (cfg.ensureUsers != []) "auth_socket.so";
       }
       (mkIf (cfg.replication.role == "master" || cfg.replication.role == "slave") {
         log-bin = "mysql-bin-${toString cfg.replication.serverId}";

@Izorkin would you be willing to prepare a PR bumping MariaDB to 10.4.12 for master?

@flokli need help to correct write release notes. To release notes need add instruction to correct upgrade database and galera cluster - https://mariadb.com/kb/en/upgrading-from-mariadb-103-to-mariadb-104-with-galera-cluster/

@Izorkin quickly skimming over the docs, what sounds relevant to us might be:

Before doing the upgrade:

• setting wsrep_provider_options="gcache.size=…G" to an appropriate value
• possibly bumping startup timeouts (?) (I assumed mysql_upgrade would do migrations, so why is this necessary?)

Then switching to the new nixpkgs version containing the bump.

After the switch:

• running mysql_upgrade --skip-write-binlog
• checking if everything is okay
• setting back wsrep_provider_options="gcache.size=…G" (?)

I must however admit I don't feel quite comfortable on giving any guidelines here. I don't operate any Galera Cluster at the moment, and would love to get more feedback from people using this in production.

cc @dasJ

Resolved by #86900

@Izorkin are you available to prepare a PR to bump mariadb to the 10.5.x series?

EDIT: Just as I commented on this I realize you already have 😆