matomo: 3.11.0 -> 3.13.0 #74319
Merged
matomo: 3.11.0 -> 3.13.0 #74319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kiwi please rebase as I merged the PR for your first commit. |
Kiwi
force-pushed
the
matomo-consistency-3.13.0
branch
from
816d00b
to
2da6f99
Compare
You just love to make me work don't you :P |
ajs124
reviewed
Nov 29, 2019
Kiwi
force-pushed
the
matomo-consistency-3.13.0
branch
from
2da6f99
to
5594fdf
Compare
ajs124
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Thanks to all for testing that Matomo 3.13 indeed fixes our problems with 3.12. Let's rework and rethink PermissionsStartOnly / the PreStart script later. I did not know of stateVersion at the time which would have been the right thing to do, but we can probably start to just drop the migration code and maybe even the piwik aliases by now as 19.09 is the second stable release with the renaming.
florianjacob
added a commit
to florianjacob/nixpkgs
that referenced
this pull request
Dec 11, 2019
backport of NixOS#74319 without the file consistency checks. 3.12 was rated a major security update but was broken for NixOS, therefore jump to 3.13 which incorporates the necessary fix.
FRidh
pushed a commit
that referenced
this pull request
Dec 11, 2019
backport of #74319 without the file consistency checks. 3.12 was rated a major security update but was broken for NixOS, therefore jump to 3.13 which incorporates the necessary fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The long awaited update to Matomo 3.12.0 has finally arrived! Here it comes... wait what do you mean you missed it?! Oh no, too slow! Well here's 3.13.0 instead!
Things done
I checked out this other PR before I made these additional changes. Now that one is clearly inferior at this point and should be closed in favor of this one so that I don't have to redo everything. 馃槃
I had to add an additional file to the list to fix; and then add in a check to keep the builds succeeding. The matomo-beta would fail when
wctried to count a non-existent file that is only in the latest and greatest. No file? No problem! nop!I also removed the recently (within the last few months, I'm sure) deprecated PermissionsStartOnly; and while I'm not certain that there aren't additional necessary changes that I am unaware of I do know I've been running it in production...sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @florianjacob @aanderse @dasJ @Kiwi