Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_13, grafana-6.5.1: backport to 19.09 #74498

Merged
merged 5 commits into from Dec 16, 2019
Merged

go_1_13, grafana-6.5.1: backport to 19.09 #74498

merged 5 commits into from Dec 16, 2019

Conversation

WilliButz
Copy link
Member

@WilliButz WilliButz commented Nov 28, 2019 •
edited

Motivation for this change

#74474

Go 1.13 is needed for building grafana >= 6.5.

Things done

Added a commit that only introduces buildGo113{Package,Module} without making them the new default.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 28, 2019
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

@WilliButz
Copy link
Member Author

rebased on the most recent release-19.09

@GrahamcOfBorg test grafana

@WilliButz WilliButz mentioned this pull request Dec 11, 2019
Merged
10 tasks
@andir
Copy link
Member

andir commented Dec 13, 2019

@WilliButz Is the 6.4.x branch out of support and suffering from significant bugs? Is there any user facing breakage by upgrading? Just asking so I can properly judge my understanding of the changelog.

@WilliButz
Copy link
Member Author

WilliButz commented Dec 14, 2019 •
edited

@andir While I do think that the grafana team would publish important security patch releases for 6.4 if they were necessary, I also think that the bug fixes in the last three releases (6.5.0 to 6.5.2), which are not available on 6.4, are worth having the slight backwards incompatibilities between minor releases, even on stable.

However I wouldn't suggest to backport major version bumps to stable.

@andir
Copy link
Member

andir commented Dec 14, 2019

You are the expert here ;-) Fine by me if you think it is reasonable to do so.

@andir andir merged commit c2ef0ce into NixOS:release-19.09 Dec 16, 2019
@WilliButz WilliButz deleted the grafana-go-backports branch December 17, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @andir @rvolosatovs