Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: fix unstable vim plugin path #74496

Merged
merged 1 commit into from Jan 4, 2020
Merged

fzf: fix unstable vim plugin path #74496

merged 1 commit into from Jan 4, 2020

Conversation

midchildan
Copy link
Member

@midchildan midchildan commented Nov 28, 2019 •
edited

Motivation for this change

Make the vim plugin path predictable by not including version numbers in it. I have also bumped the version from 0.18.0 to 0.19.0. (rebased)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@midchildan midchildan changed the title Fix fzf vim plugin path fzf: exclude version number from vim plugin path Nov 28, 2019
@ofborg ofborg bot requested a review from kalbasit November 28, 2019 14:43
@midchildan
fzf: fix unstable vim plugin path
bc213d0 
exclude version number from vim plugin path
@midchildan midchildan changed the title fzf: exclude version number from vim plugin path fzf: fix unstable vim plugin path Jan 4, 2020
@ofborg ofborg bot requested review from Br1ght0ne and Ma27 January 4, 2020 14:59
Br1ght0ne
Br1ght0ne approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ma27 Ma27 merged commit 502ef3c into NixOS:master Jan 4, 2020
@midchildan midchildan deleted the fix-fzf-vim-plugin-path branch January 12, 2020 23:46
midchildan added a commit to midchildan/dotfiles that referenced this pull request Apr 29, 2020
@midchildan
vim: Use plugin bundled in nixpkgs.fzf package
50069cd 
This follows NixOS/nixpkgs#74496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@midchildan @Ma27 @Br1ght0ne