Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libappindicator: remove python2 #74359

Merged
merged 1 commit into from Nov 28, 2019
Merged

libappindicator: remove python2 #74359

merged 1 commit into from Nov 28, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

馃憢 Would be nice if, in general, less things depended on this in nixpkgs.
stuff found when doing #74295 (comment)

It's possible something needed this, but idc, let them break for now 馃ぃ .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace added this to To do in Picking up garbage via automation Nov 27, 2019
@worldofpeace worldofpeace added this to Needs review in Python 2 deprecation Nov 27, 2019
@worldofpeace worldofpeace moved this from To do to In progress in Picking up garbage Nov 27, 2019
jtojnar
jtojnar approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but LGTM. We could probably get rid of monoSupport as well.

@jtojnar jtojnar merged commit 60779d0 into NixOS:master Nov 28, 2019
Picking up garbage automation moved this from In progress to Done Nov 28, 2019
Python 2 deprecation automation moved this from Needs review to Done Nov 28, 2019
@jtojnar jtojnar deleted the libappindicator-no-python2 branch November 28, 2019 12:14
@jtojnar
Copy link
Contributor

jtojnar commented Nov 28, 2019

Nice, this reduced my system from 171 boxes to 148:

old

new

Drv tool

Based on NixOS/nix#1918 (comment)

#!/usr/bin/env nix-shell
#!nix-shell -p graphviz -p python3.pkgs.xdot -i bash

if (( $# != 2 )); then
    echo "usage: locate.sh <parent> <child>"
    exit 1
fi

if [[ "$1" =~ \.drv$ ]]; then
    parent=$1
else
    parent=$(nix-instantiate '<nixpkgs>' -A "$1")
fi

if [[ "$2" =~ \.drv$ ]]; then
    child=$2
else
    child=$(nix-instantiate '<nixpkgs>' -A "$2")
fi

nix-store -q --graph "$parent" | dijkstra -da "$child" | gvpr -c 'N[dist>1000.0]{delete(NULL, $)}' | xdot -

@nyanloutre
Copy link
Member

GTK2 build of this library is failing since this commit: https://hydra.nixos.org/build/107472670/nixlog/1

@nyanloutre
Copy link
Member

I made a fix here: #74733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
Picking up garbage
  
Done
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @nyanloutre @Ma27