Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildUBoot: allow passing custom src #74363

Merged
merged 1 commit into from Nov 27, 2019
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 27, 2019

We allowed passing another version, but that wasn't too useful, given we
hardcoded the hash of the fetchurl.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/misc/uboot/default.nix Outdated Show resolved Hide resolved
We allowed passing another version, but that wasn't too useful, given we
hardcoded the hash of the fetchurl.
@samueldr samueldr merged commit 0ee0489 into NixOS:master Nov 27, 2019
@flokli flokli deleted the builduboot-src branch November 27, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants