Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
opencv2 is essentially EOL and has security concerns
This is a bit of a funny PR, in that the result I'm proposing compiles but doesn't actually work for me. But neither did the existing package. While the module compiles fine, in both cases if you observe the startup log it fails to load
lib/saga/libimagery_opencv.so
. Perhaps I'm testing it wrong, so I'm appealing to maintainers @michelk and @mpickering to ask if you ever had the opencv features working forsaga
.