Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saga: switch to opencv3 #74288

Closed
wants to merge 1 commit into from
Closed

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 26, 2019

Motivation for this change

opencv2 is essentially EOL and has security concerns

This is a bit of a funny PR, in that the result I'm proposing compiles but doesn't actually work for me. But neither did the existing package. While the module compiles fine, in both cases if you observe the startup log it fails to load lib/saga/libimagery_opencv.so. Perhaps I'm testing it wrong, so I'm appealing to maintainers @michelk and @mpickering to ask if you ever had the opencv features working for saga.

opencv2 is essentially EOL and has security concerns
@mpickering
Copy link
Contributor

I don't think I ever tested this part of saga and am not a regular user.

@doronbehar
Copy link
Contributor

What about opencv4?

@risicle
Copy link
Contributor Author

risicle commented May 19, 2020

This was quite a while ago now, but when I was doing this I generally would have switched to opencv4 if it worked, so I assume opencv4 broke it.

@doronbehar
Copy link
Contributor

I think I once searched for a statement from upstream that saga supports opencv3/4 and I couldn't find any at https://sourceforge.net/p/saga-gis/bugs/search/?q=opencv although the project seems active according to their releases.

@doronbehar
Copy link
Contributor

@doronbehar
Copy link
Contributor

I've successfully built saga with opencv4 now that upstream has responded: #94619

@doronbehar doronbehar mentioned this pull request Aug 3, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants