Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: use latest qt #74289

Merged
merged 1 commit into from
Mar 4, 2020
Merged

zoom-us: use latest qt #74289

merged 1 commit into from
Mar 4, 2020
+1 −1

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #74273
And this is a maybe fixes because I cannot reproduce this issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@worldofpeace worldofpeace mentioned this pull request Nov 26, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 26, 2019
matthewbauer
matthewbauer reviewed Nov 26, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -21608,7 +21608,7 @@ in
inherit (darwin.apple_sdk.frameworks) CoreServices;
};

zoom-us = libsForQt59.callPackage ../applications/networking/instant-messengers/zoom-us { };
zoom-us = libsForQt5.callPackage ../applications/networking/instant-messengers/zoom-us { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was done with 5.9 originally because that's what zoom bundles with. CHanging it to 5.12 could cause ABI incompatibilities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On master it uses latest qt... This on stable also, so the version isn't going to change.

We should probably pin it to what it's bundled on master (check this to).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qt has an ABI stability guarantee. It's always forward compatible.

@danbst danbst mentioned this pull request Dec 16, 2019
Closed
@worldofpeace worldofpeace merged commit 8121ff2 into NixOS:release-19.09 Mar 4, 2020
@worldofpeace worldofpeace deleted the fix-zoom-19.09 branch March 4, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer

@adisbladis adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @matthewbauer @adisbladis