Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topgrade: 3.4.0 -> 3.5.0 #74438

Merged
merged 1 commit into from Nov 30, 2019
Merged

topgrade: 3.4.0 -> 3.5.0 #74438

merged 1 commit into from Nov 30, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 28, 2019 •
edited

Motivation for this change

https://github.com/r-darwish/topgrade/releases/tag/v3.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/h4cfq7gn01g46swpjv61imbr94igf6al-topgrade-3.4.0	  29.2M
/nix/store/4iq5ris5ybc7wd84p5fiwjblwy7fhbij-topgrade-3.5.0	  29.1M

This change is Reviewable

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2019

@GrahamcOfBorg build topgrade

c0bw3b
c0bw3b approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 74438 1

1 package were build:
  • topgrade

Builds and dry-run ok

@c0bw3b c0bw3b merged commit 144147e into NixOS:master Nov 30, 2019
@Br1ght0ne Br1ght0ne deleted the topgrade-3.5.0 branch December 2, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @Mic92 @c0bw3b