Cookie Store: Refactor tests to also work in window context. #20468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 27, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1851232
branch
2 times, most recently
from
c324ad9
to
d58b2da
Compare
This refactor condenses service worker test files by converting the service worker scripts into .any.js WPT files that test both window and worker contexts. Change-Id: Iee64f5cc68b939ab02b06910444b8ebffdf359a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851232 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720381}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1851232
branch
from
d58b2da
to
04a7455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor condenses service worker test files by converting the
service worker scripts into .any.js WPT files that test both window and
worker contexts.
Change-Id: Iee64f5cc68b939ab02b06910444b8ebffdf359a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851232
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720381}