Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: a12c0ed2834a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 059faab65aee
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 26, 2019

  1. buildRustCrate: add lib output

    This cuts down the dependency tree on some rust builds where a crate not
    just exposes a binary but also a library. `$out/lib` contained a bunch
    of extra support files that among other information carry linker flags
    (including the full path to link-time dependencies). Worst case this led
    to some binary outputs depending on the full build closure of rust
    crates.
    
    Moving all the `$out/lib` files to `$lib/lib` solves this nicely.
    
    `lib` might be a bit weird here as they are most of the time just rlib
    files (rust libraries). Those are essential only required during
    compilation but they can also be shared objects (like with traditional
    C-style packages). Which is why I went with `lib` for the new output.
    
    One of the caveats we are running into here is that we do not (always)
    know ahead of time of a crate produces just a library or just a binary.
    Cargo allows for some ambiguity regarding whether or not a crate
    provides one, two, … binaries and libraries as it's outputs. Ideally we
    would be able to rely on the `crateType` entirely but so far that isn't
    the case. More work on that area might show how difficult that actually
    is.
    andir committed Nov 26, 2019
    Copy the full SHA
    1b74855 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Merge pull request #73803 from andir/buildRustCrate-lib-output

    buildRustCrate: add lib output
    andir committed Nov 28, 2019
    Copy the full SHA
    059faab View commit details
    Browse the repository at this point in the history