Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryfs: 0.9.10 -> 0.10.2 #74296

Merged
merged 1 commit into from Nov 29, 2019
Merged

cryfs: 0.9.10 -> 0.10.2 #74296

merged 1 commit into from Nov 29, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 26, 2019

Motivation for this change

Package update
+ re-enable tests after #56391

I'm not replacing the bundled spdlog because spdlog is just a bunch of headers and there is no closure-size gain to unbundle it. Plus we have to maintain an old spdlog 0.16.x just for cryfs, so after this we would be able to keep just one spdlog in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/xzw0j3ms9wwqvmdv6ycybwdh113j8pcp-cryfs-0.9.10           3.0M  133.2M
/nix/store/rh5757ybi5a846k8z8l6xqghbzs44img-cryfs-0.10.2           4.0M  162.7M
Notify maintainers

cc @peterhoeg


$ /nix/store/rh5757ybi5a846k8z8l6xqghbzs44img-cryfs-0.10.2/bin/cryfs --show-ciphers
CryFS Version 0.10.2

aes-256-gcm
aes-256-cfb
aes-128-gcm
aes-128-cfb
twofish-256-gcm
twofish-256-cfb
twofish-128-gcm
twofish-128-cfb
serpent-256-gcm
serpent-256-cfb
serpent-128-gcm
serpent-128-cfb
cast-256-gcm
cast-256-cfb
mars-448-gcm
mars-448-cfb
mars-256-gcm
mars-256-cfb
mars-128-gcm
mars-128-cfb

I created a new encrypted dir and I could mount, add files, unmount and re-mount without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant