Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config option to immediately edit dimensions #514

Merged
merged 2 commits into from Nov 26, 2019

Conversation

vespakoen
Copy link
Contributor

Here it is again, this time with config option.

Let me know if the default should be on or off, and if the variables / place in the preferences pane are fine with you.

The option does now also work on the angle constraint.

Copy link
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK other than the comment.

@@ -342,6 +347,9 @@ void TextWindow::ShowConfiguration() {
SS.automaticLineConstraints ? CHECK_TRUE : CHECK_FALSE);
Printf(false, " %Fd%f%Ll%s use turntable mouse navigation%E", &ScreenChangeTurntableNav,
SS.turntableNav ? CHECK_TRUE : CHECK_FALSE);
Printf(false, " %Fd%f%Ll%s immediately edit dimensions%E",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about edit newly added dimensions? The variable naming is fine, but the preference is a bit confusing.

@whitequark
Copy link
Contributor

Let me know if the default should be on or off

The existing behavior should not change for people who are already using SolveSpace.

@vespakoen
Copy link
Contributor Author

Changed the default to false and used your suggested label.
Just have to figure out how to squash these commits together now =)

Will take a bit...

@whitequark
Copy link
Contributor

whitequark commented Nov 26, 2019

I can just squash while merging in a simple case like this, GitHub has a button for it.

@vespakoen
Copy link
Contributor Author

Cool! then I leave it =)
Was just running

git reset --soft HEAD~2

Which seemed to work allright =)

@whitequark
Copy link
Contributor

Usually people use git rebase -i which is a bit more flexible, but that works too.

@vespakoen
Copy link
Contributor Author

Indeed, I am not very familiar with git I notices since I mostly only commit and push things with it, should read the manual again...

@vespakoen
Copy link
Contributor Author

Force pushed it anyway ;)

@whitequark
Copy link
Contributor

This needs a changelog addition as well.

@whitequark whitequark merged commit dcdfdec into solvespace:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants