Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm-agent: 2.0.633.0 -> 2.3.760.0 #74384

Closed
wants to merge 1 commit into from
Closed

ssm-agent: 2.0.633.0 -> 2.3.760.0 #74384

wants to merge 1 commit into from

Conversation

mwu
Copy link

@mwu mwu commented Nov 27, 2019 •
edited

Bumping version and switching to Amazon's executable names

Motivation for this change

To bring the ssm-agent up to date and support new features like AWS Session Manager and SSM SSH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Tested aws ssm start-session works, as does using it as an ssh ProxyCommand. Also tested ssm runShellScript via the AWS console.
Notify maintainers

cc @copumpkin

@mwu
ssm-agent: 2.0.633.0 -> 2.3.760.0
765937b 
Bumping version and switching to Amazon's executable names
@ofborg ofborg bot requested review from copumpkin and ehmry November 27, 2019 23:16
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@manveru manveru mentioned this pull request Jun 26, 2020
Merged
10 tasks
@Lassulus
Copy link
Member

this is now obsolete because of #91586

@Lassulus Lassulus closed this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwu @Lassulus @Janik-Haag