Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overpass: 3.0.3 -> 3.0.4 #74294

Closed
wants to merge 1 commit into from
Closed

overpass: 3.0.3 -> 3.0.4 #74294

wants to merge 1 commit into from

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Nov 26, 2019

Motivation for this change

line height issues fixed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rycee

@ofborg ofborg bot requested a review from rycee November 26, 2019 21:36
@rycee rycee self-assigned this Nov 26, 2019
@rycee
Copy link
Member

rycee commented Nov 26, 2019

Works well, thanks for the fix! Rebased to master in 6d7145b.

@rycee rycee closed this Nov 26, 2019
@dywedir dywedir deleted the overpass branch November 27, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees

@rycee rycee

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @rycee