Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyocclient: init at 0.4 #68862

Closed
wants to merge 1 commit into from
Closed

pyocclient: init at 0.4 #68862

wants to merge 1 commit into from

Conversation

Qubasa
Copy link
Contributor

@Qubasa Qubasa commented Sep 15, 2019 •
edited

pyocclient: init at 0.4

Motivation for this change

Owncloud / Nextcloud interface python library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Qubasa
pyocclient: init at 0.4
027ec62 
pyocclient: init at 0.4
@Qubasa Qubasa requested a review from FRidh as a code owner September 15, 2019 20:47
mmahut
mmahut reviewed Sep 16, 2019
View reviewed changes
pkgs/development/python-modules/pyocclient/default.nix
homepage = https://github.com/owncloud/pyocclient/;
description = "Nextcloud / Owncloud library for python";
license = licenses.mit;
maintainers = with maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to ack as a maintainer for this package? We are hesitant to add any more unowned packages.

Copy link
Contributor Author

@Qubasa Qubasa Sep 17, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I could but I won't update the package so I think it is more representative to not add a maintainer in that case

@Qubasa Qubasa closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Qubasa @mmahut