Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

josm: 15390 -> 15492 #74311

Closed
wants to merge 1 commit into from
Closed

josm: 15390 -> 15492 #74311

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Nov 27, 2019

Motivation for this change

Changelog (2019-11-02: Stable release 15492)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/winjkf1598jb8j6qc5wx39hkqy11lhdq-josm-15390
/nix/store/winjkf1598jb8j6qc5wx39hkqy11lhdq-josm-15390	   1.0G
$ nix path-info -Sh /nix/store/ywnk2558hvr27z8p2pf29l6g0gx1yiw9-josm-15492
/nix/store/ywnk2558hvr27z8p2pf29l6g0gx1yiw9-josm-15492	   1.0G
Notify maintainers

cc @rycee

@rycee
Copy link
Member

rycee commented Nov 27, 2019

Seems to work fine. Thanks for the update! Rebased to master in f0b5b24.

@rycee rycee closed this Nov 27, 2019
@sikmir sikmir deleted the josm branch November 27, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants