Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.memcached: port to python #74312

Merged
merged 1 commit into from Nov 27, 2019
Merged

nixosTests.memcached: port to python #74312

merged 1 commit into from Nov 27, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 27, 2019 •
edited

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

This change is Reviewable

tfc
tfc reviewed Nov 27, 2019
View reviewed changes
nixos/tests/memcached.nix Outdated Show resolved Hide resolved
@tfc tfc mentioned this pull request Nov 27, 2019
Closed
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg test memcached

@globin globin merged commit 470f29c into NixOS:master Nov 27, 2019
@Br1ght0ne Br1ght0ne deleted the nixosTests.memcached-python branch November 27, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @tfc @globin