Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch: place-constraints #335

Closed
4 tasks
acomodi opened this issue Nov 28, 2019 · 2 comments
Closed
4 tasks

Branch: place-constraints #335

acomodi opened this issue Nov 28, 2019 · 2 comments
Labels
wip Work in Progress branch that needs work to be deleted/sent upstream
Projects
Merge changes upstream

Comments

@acomodi
Copy link
Collaborator

acomodi commented Nov 28, 2019

Why did we need this? (what does this change enable us to do)

We need this to allow VPR using and detecting user-defined placement constraints to allow also the fixed placement of blocks different from IOs.

What did it change?

Initial placement

Should it be merged upstream - if not, when can we delete it?

No. This is a temporary workaround to solve f4pga/f4pga-arch-defs#1182. When verilog-to-routing#1045 gets solved, we won't need this patch anymore

What is needed to get this merged / deleted?

  • is the implementation work to make suitable for merging / deletion completed?
  • Is there an associated test?
  • is this currently part of the Conda package?
  • is this properly cleaned up in our local repositories?

Tracker / branch / PR & other useful links
@acomodi acomodi added the wip Work in Progress branch that needs work to be deleted/sent upstream label Nov 28, 2019
@acomodi acomodi added this to Not for merging upstream in Merge changes upstream Nov 28, 2019
@litghost
Copy link

litghost commented Mar 4, 2020

I've opened an upstream PR, as this branch is generally useful: verilog-to-routing#1189

@litghost litghost moved this from Not for merging upstream to PR open with upstream in Merge changes upstream Mar 4, 2020
@litghost litghost mentioned this issue Mar 4, 2020
Closed
4 tasks
@acomodi acomodi moved this from PR open with upstream to In Conda Package - Pending other cleanup in Merge changes upstream Mar 11, 2020
@acomodi
Copy link
Collaborator Author

acomodi commented Mar 11, 2020

This has been merged upstream. closing

@acomodi acomodi closed this as completed Mar 11, 2020
Merge changes upstream automation moved this from In Conda Package - Pending other cleanup to Completed (merged upstream & used locally) Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wip Work in Progress branch that needs work to be deleted/sent upstream
Projects
Merge changes upstream
  
Completed (merged upstream & used...
Milestone
No milestone
Development

No branches or pull requests
2 participants
@litghost @acomodi