Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-insta: init at 0.16.0 #74487

Merged
merged 2 commits into from Jun 18, 2020
Merged

cargo-insta: init at 0.16.0 #74487

merged 2 commits into from Jun 18, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Nov 28, 2019 •
edited

Motivation for this change

New package: cargo-insta, a popular cargo subcommand for snapshot testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • ~32 MB
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@oxalica oxalica changed the title cargo-insta: new at 0.12.0 cargo-insta: init at 0.12.0 Nov 28, 2019
@oxalica oxalica force-pushed the cargo-insta branch 2 times, most recently from e1fa814 to 63e5bd3 Compare February 10, 2020 20:18
@oxalica oxalica changed the title cargo-insta: init at 0.12.0 cargo-insta: init at 0.13.1 Feb 10, 2020
@oxalica
Copy link
Contributor Author

oxalica commented Feb 10, 2020

Rebased and updated to 0.13.1

@oxalica oxalica mentioned this pull request Apr 16, 2020
Closed
@oxalica oxalica changed the title cargo-insta: init at 0.13.1 cargo-insta: init at 0.16.0 Apr 16, 2020
danieldk
danieldk suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this while going through older PRs. Sorry that this slipped through the cracks!

pkgs/development/tools/rust/cargo-insta/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rust/cargo-insta/default.nix Show resolved Hide resolved
pkgs/development/tools/rust/cargo-insta/default.nix Outdated Show resolved Hide resolved
@oxalica oxalica requested a review from danieldk June 18, 2020 11:16
@oxalica oxalica requested a review from danieldk June 18, 2020 12:50
danieldk
danieldk approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Result of nixpkgs-review pr 74487 1

1 package built:
- cargo-insta

Binary runs successfully.

@danieldk danieldk merged commit f7214fa into NixOS:master Jun 18, 2020
@oxalica oxalica deleted the cargo-insta branch June 18, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxalica @danieldk