Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eth-utils and and eth-typing #74342

Closed
wants to merge 2 commits into from
Closed

Update eth-utils and and eth-typing #74342

wants to merge 2 commits into from

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Nov 27, 2019 •
edited

Motivation for this change

Update Python packages eth-utils and eth-typing.

Running nix review:

[...]$ nix-review rev -b nixos-unstable update-eth-utils-and-typing
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs nixos-unstable:refs/nix-review/0
$ git worktree add /home/jluttine/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea/nixpkgs e89b21504f3e61e535229afa0b121defb52d2a50
Preparing worktree (detached HEAD e89b21504f3)
Updating files: 100% (20378/20378), done.
HEAD is now at e89b21504f3 Merge pull request #73729 from marsam/update-ibm-plex
$ nix-env -f /home/jluttine/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 2a98a44f75d6e2fcb4298b332194fd80024eb4ea
Updating e89b21504f3..2a98a44f75d
Fast-forward
 pkgs/development/python-modules/eth-typing/default.nix | 4 ++--
 pkgs/development/python-modules/eth-utils/default.nix  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
$ nix-env -f /home/jluttine/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/jluttine/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
[16 built, 52 copied (69.8 MiB), 25.7 MiB DL]
16 package were built:
electron-cash electrum keepkey_agent python37Packages.eth-typing python37Packages.eth-utils python37Packages.keepkey python37Packages.rlp python37Packages.trezor trezor_agent python38Packages.eth-typing python38Packages.eth-utils python38Packages.keepkey python38Packages.keepkey_agent python38Packages.rlp python38Packages.trezor python38Packages.trezor_agent

[0.0 MiB DL]
$ nix-shell /home/jluttine/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea/shell.nix

[nix-shell:~/.cache/nix-review/rev-2a98a44f75d6e2fcb4298b332194fd80024eb4ea]$
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

failures are unrelated to this package

[14 built (2 failed), 3 copied (4.0 MiB), 4.0 MiB DL]
error: build of '/nix/store/7ag6zqxqvds6bfln7rbys95w7bixdvyr-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74342
4 package failed to build:
keepkey_agent trezor_agent python38Packages.keepkey_agent python38Packages.trezor_agent

12 package were built:
electron-cash electrum python37Packages.eth-typing python37Packages.eth-utils python37Packages.keepkey python37Packages.rlp python37Packages.trezor python38Packages.eth-typing python38Packages.eth-utils python38Packages.keepkey python38Packages.rlp python38Packages.trezor

@jonringer
Copy link
Contributor

@GrahamcOfBorg build electron-cash electrum python37Packages.eth-typing python37Packages.eth-utils python37Packages.keepkey python37Packages.rlp python37Packages.trezor python38Packages.eth-typing python38Packages.eth-utils python38Packages.keepkey python38Packages.rlp python38Packages.trezor

@jluttine
Copy link
Member Author

jluttine commented Mar 9, 2020

See this PR instead: #82165

@jluttine jluttine closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @jonringer