Always update intervals using the "latest update time" #20482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 27, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1939788
branch
from
1457624
to
fea2ba7
Compare
For interval updates performed "outside" of the regular flow in SMILTimeContainer, we would use the "previous" presentation - i.e the time just before the time we latest updated timing to. This could cause elements to resolve intervals in the past - for example when the latest update time was at the end of an interval it could discard the current interval and resolve an interval in the past, which could then be propagated to its dependents. When these elements were later updated by the main update loop they would again discard the current (in the past) interval and resolve a new one, notifying its dependents. Repeat. Instead always use the "latest update time" (the same is used by SMILTimeContainer::UpdateIntervals) as the argument to Updateinterval(), and only use the "previous" presentation time when checking if the active state may have changed in a relevant way and for rescheduling. Bug: 1021630, 1028839, 1029327 Change-Id: Ibe691ae336df51a36626fdd800e5ddc2303aee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939788 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720669}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1939788
branch
from
fea2ba7
to
451f295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For interval updates performed "outside" of the regular flow in
SMILTimeContainer, we would use the "previous" presentation - i.e the
time just before the time we latest updated timing to. This could cause
elements to resolve intervals in the past - for example when the latest
update time was at the end of an interval it could discard the current
interval and resolve an interval in the past, which could then be
propagated to its dependents. When these elements were later updated by
the main update loop they would again discard the current (in the past)
interval and resolve a new one, notifying its dependents. Repeat.
Instead always use the "latest update time" (the same is used by
SMILTimeContainer::UpdateIntervals) as the argument to Updateinterval(),
and only use the "previous" presentation time when checking if the
active state may have changed in a relevant way and for rescheduling.
Bug: 1021630, 1028839, 1029327
Change-Id: Ibe691ae336df51a36626fdd800e5ddc2303aee5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939788
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#720669}