tests/wireguard: init wg-quick #74504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test wg-quick |
Ma27
reviewed
Dec 19, 2019
nixos/tests/wireguard/default.nix
Outdated
| ipv6.addresses = lib.singleton { | ||
| address = "fd00::1"; | ||
| prefixLength = 64; | ||
| peer0 = { lib, ... }: lib.attrsets.recursiveUpdate ( |
There was a problem hiding this comment.
When updating nixos configurations, it's generally safer to use lib.mkMerge.
There was a problem hiding this comment.
Done. I'm curious what the difference is though? I couldn't find any documentation for lib.mkMerge in the nixpkgs manual...
Thanks @Ma27 for the review :) |
|
@GrahamcOfBorg test wg-quick |
|
@Ma27 Is there anything more to do here? |
- Duplicate and adapt the existing default wireguard test for wg-quick - Pull common setup code out into a seperate file
|
spotted some issues after I asked 馃榿
rebased on master and made the above changes. I think this should be good to go now 馃檪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While updating
wireguard-toolsin #74347 I missed a new dependency inwg-quick, and my brief testing ofwg-quick(executing thewg-quickbinary with no arguments) failed to detect the oversight. Once merged this broke thewg-quickmodule (also on stable! 馃槩).This change adds a simple test for the
wg-quickmodule to thetests/wireguardfolder, that should hopefully avoid similar situations in the future.Changes:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @elseym @ericsagnes @Mic92 @globin @Ma27 @iclanzan