aws-sam-cli: 0.22.0 -> 0.34.0 #74329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
nix-review passes (failures look unrelated to aws-sam-cli)
diff LGTM
[125 built (24 failed), 483 copied (2824.4 MiB), 573.8 MiB DL]
error: build of '/nix/store/s3l6kys2s88m5xzrwwzdy802s85b80nj-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74329
1 package are marked as broken and were skipped:
python37Packages.imgaug
28 package failed to build:
apache-airflow python27Packages.atomman python27Packages.hvplot python27Packages.imbalanced-learn python27Packages.nipype python27Packages.pymatgen python27Packages.sumo python27Packages.uproot python37Packages.atomman python37Packages.blaze python37Packages.dask-ml python37Packages.google_cloud_bigquery python37Packages.hvplot python37Packages.ibis-framework python37Packages.imbalanced-learn python37Packages.intake python37Packages.mesa python37Packages.nipype python37Packages.odo python37Packages.optuna python37Packages.rl-coach python37Packages.sentry-sdk python37Packages.slicedimage python37Packages.starfish python37Packages.streamz python37Packages.sunpy python37Packages.uproot python37Packages.vega
112 package were built:
aws-sam-cli buildbot buildbot-full buildbot-ui csvs-to-sqlite paperwork poretools python27Packages.Quandl python27Packages.altair python27Packages.awkward python27Packages.aws-lambda-builders python27Packages.aws-sam-translator python27Packages.bkcharts python27Packages.celery python27Packages.cfn-lint python27Packages.cnvkit python27Packages.cufflinks python27Packages.djmail python27Packages.drms python27Packages.fastparquet python27Packages.geopandas python27Packages.histbook python27Packages.holoviews python27Packages.mapsplotlib python27Packages.moto python27Packages.pandas python27Packages.partd python27Packages.pyarrow python27Packages.pybids python27Packages.pytrends python27Packages.seaborn python27Packages.statsmodels python27Packages.tablib python27Packages.trackpy python27Packages.uproot-methods python27Packages.vega python27Packages.vega_datasets python27Packages.vidstab python37Packages.Quandl python37Packages.acoustics python37Packages.altair python37Packages.aplpy python37Packages.awkward python37Packages.aws-lambda-builders python37Packages.aws-sam-translator python37Packages.bkcharts python37Packages.caffe python37Packages.celery python37Packages.cfn-lint python37Packages.cnvkit python37Packages.cufflinks python37Packages.dask python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datashader python37Packages.dftfit python37Packages.distributed python37Packages.djmail python37Packages.drms python37Packages.fastparquet python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_monitoring python37Packages.histbook python37Packages.holoviews python37Packages.image-match python37Packages.lammps-cython python37Packages.moto python37Packages.osmnx python37Packages.pandas python37Packages.partd python37Packages.phik python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pymc3 python37Packages.pytrends python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.statsmodels python37Packages.stumpy python37Packages.sumo python37Packages.tablib python37Packages.trackpy python37Packages.uproot-methods python37Packages.vega_datasets python37Packages.vidstab python37Packages.wrf-python python37Packages.xarray python37Packages.xgboost python38Packages.aws-lambda-builders python38Packages.aws-sam-translator python38Packages.cfn-lint sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht streamlit visidata
please just invert the order of the commits, (if i were to just check out the first one, aws-sam-cli would be broken)
git rebase -i HEAD~3
# invert commit order
# save buffer
git push --force <fork> <branch>
lo1tuma
force-pushed
the
aws-sam-cli-0331
branch
from
6fd2ea1
to
70f05ef
Compare
|
@jonringer Thanks for the feedback. I’ve changed the commit order as suggested. |
lo1tuma
force-pushed
the
aws-sam-cli-0331
branch
from
70f05ef
to
ff1326d
Compare
|
the commits tab doesnt look like it's changed, but your branch looks fine |
|
@GrahamcOfBorg build aws-sam-cli |
jonringer
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Release Notes
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)