Fix tooltips not closing on macOS Catalina #516
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, and thank you for the investigation and fix! I know figuring out private APIs can be quite frustrating. |
|
I got quite lucky figuring out the new magic method to close the tooltip,
and with a little help of "class-dump" ofcourse :)
…On Wed, 27 Nov 2019 at 13:51, whitequark ***@***.***> wrote:
Looks good, and thank you for the investigation and fix! I know figuring
out private APIs can be quite frustrating.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#516?email_source=notifications&email_token=AAGV4VNLP6V525E6VYVFM73QVZUOZA5CNFSM4JR7D3H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJM5DY#issuecomment-559074959>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGV4VMVE3SIL7JWNK7WJODQVZUOZANCNFSM4JR7D3HQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last bug I have found on Catalina.
Tooltips are not closed when hovering off something.
The private API seems to have changed, and implementing tooltips seems to be a pain in the butt, so I checked for the availability of the method and fall back to the old method for now.