Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qjoypad: 4.1.0 -> 4.3.0 #74330

Closed
wants to merge 2 commits into from
Closed

qjoypad: 4.1.0 -> 4.3.0 #74330

wants to merge 2 commits into from

Conversation

radraw
Copy link

@radraw radraw commented Nov 27, 2019

Motivation for this change

Switching to Qt5 makes the package play well with modern desktop environments. Tested on Ubuntu 18.04, default Ubuntu session.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @astsmtl

@ofborg ofborg bot requested a review from astsmtl November 27, 2019 13:05
jonringer
jonringer reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running it as is creates:

[nix-shell:/home/jon/.cache/nix-review/pr-74330-1]$ ./results/qjoypad/bin/qjoypad
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

please read: https://nixos.org/nixpkgs/manual/#sec-language-qt

pkgs/tools/misc/qjoypad/default.nix Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

dont forget to squash the commits

git reset HEAD~8
git add pkgs/
git commit --amend --no-edit
git push <fork> <branch> --force

@radraw
Copy link
Author

radraw commented Dec 28, 2019

Now when I run nix-build, I get this error:
error: syntax error, unexpected '}', at /home/radek/proj/nixpkgs/pkgs/tools/misc/qjoypad/default.nix:40:1

jonringer
jonringer reviewed Dec 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash all the commits to adhere to contributing.md

git reset HEAD~4
git add pkgs/
git commit --amend --no-edit
git push <fork> <branch> --force

@radraw
Copy link
Author

radraw commented Dec 29, 2019

Done, thank you for your help !

@jonringer
Copy link
Contributor

please resolve conflict, otherwise it LGTM

@drewrisinger
Copy link
Contributor

ping @radraw for resolving merge conflict

@radraw
Copy link
Author

radraw commented Jul 31, 2020

I see the change hasn't been picked yet. Is something missing I can help to proceed with it ?

jonringer
jonringer reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to have clean git histories, please rebase on top of the target branch:

git pull -r origin master

instead of merging upstream into your branch :)
should just be 1 commit

pkgs/tools/misc/qjoypad/default.nix Outdated
license = stdenv.lib.licenses.gpl2;
maintainers = with stdenv.lib.maintainers; [ astsmtl ];
platforms = with stdenv.lib.platforms; linux;
homepage = https://github.com/panzi/qjoypad;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfc 45

Suggested change
homepage = https://github.com/panzi/qjoypad;
homepage = "https://github.com/panzi/qjoypad";

SuperSandro2000
SuperSandro2000 requested changes Mar 21, 2021
View reviewed changes
pkgs/tools/misc/qjoypad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Show resolved Hide resolved
pkgs/tools/misc/qjoypad/default.nix Show resolved Hide resolved
@stale
Copy link

stale bot commented Apr 16, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 16, 2022
@radraw @SuperSandro2000
Update pkgs/tools/misc/qjoypad/default.nix
f0d25fe 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 15, 2022
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@radraw @jonringer @drewrisinger @SuperSandro2000 @bobby285271 @Artturin @Janik-Haag