Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplenote: 1.9.1 -> 1.11.0 #74467

Merged
merged 1 commit into from Nov 28, 2019
Merged

simplenote: 1.9.1 -> 1.11.0 #74467

merged 1 commit into from Nov 28, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Nov 28, 2019

also fixed this; Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Kiwi Kiwi force-pushed the simplenote-update branch 2 times, most recently from f785bb7 to 8f50e51 Compare November 28, 2019 17:09
worldofpeace
worldofpeace approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested execution.

Can't test it works properly, I don't use the service.
Saw release notes https://github.com/Automattic/simplenote-electron/blob/a20eebc4ea948741a1b909e6f29f8765d3d4558e/RELEASE-NOTES.txt.

@worldofpeace worldofpeace merged commit a1ea2cf into NixOS:master Nov 28, 2019
@Kiwi Kiwi deleted the simplenote-update branch November 28, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kiwi @worldofpeace