Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tesserocr: init at 2.5.0 #74389

Merged
merged 2 commits into from Nov 30, 2019
Merged

python3Packages.tesserocr: init at 2.5.0 #74389

merged 2 commits into from Nov 30, 2019

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Nov 27, 2019

Motivation for this change

This is an attempt of adding tesserocr to nixpkgs, there are already some wrappers for tesseract in nixpkgs, but I need this one and it seems there's no derivation yet (so I put myself as maintainer).

Any comments on this derivation are always welcome. I'm currently not sure on how to test a python library, but the derivation compiles.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mtrsk mtrsk force-pushed the add-python-packages branch 3 times, most recently from 52dd0f4 to 9d32e57 Compare November 28, 2019 03:38
@jonringer
Copy link
Contributor

jonringer commented Nov 28, 2019 •
edited

the commit message should reflect the install path (what you put into nix-build), so your commit should be "{package path}: {message}":

in your case:

python3Packages.tesserocr: init at 2.5.0

@mtrsk mtrsk changed the title python-modules/tesserocr: init at 2.5.0 python3Packages.tesserocr: init at 2.5.0 Nov 28, 2019
@mtrsk mtrsk requested a review from jonringer November 29, 2019 20:45
jonringer
jonringer approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/74389
3 package were built:
python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr

@jonringer
Copy link
Contributor

can you mark this as linux only? unless you want to trouble shoot why darwin is failing on dlopen

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr

@jonringer
Copy link
Contributor

LGTM

@jonringer jonringer merged commit cc44901 into NixOS:master Nov 30, 2019
@mtrsk mtrsk deleted the add-python-packages branch December 1, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtrsk @jonringer