Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.astroquery: fix build #74479

Merged
merged 1 commit into from Nov 28, 2019
Merged

pythonPackages.astroquery: fix build #74479

merged 1 commit into from Nov 28, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Nov 28, 2019 •
edited

Motivation for this change

pythonPackages.astroquery has been broken since the update to 0.3.10 (see ffcbccf). This is because we apply an upstream patch that has been included in 0.3.10. This PR removes the patch to fix the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
pythonPackages.astroquery: fix build
eb16eb5 
The patch from upstream repository has been included in the latest
release (0.3.10), so we don't need it anymore.
@Mic92 Mic92 merged commit 19c8402 into NixOS:master Nov 28, 2019
@smaret smaret deleted the fix-astroquery branch November 28, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @Mic92