New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
akira-unstable: init at 2019-10-12 #74332
Conversation
cc @worldofpeace for qt/gtk wrapping review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
gui opens fine
[3 built, 3 copied (15.4 MiB), 2.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74332
1 package were built:
akira
@GrahamcOfBorg build akira |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please follow the code style like this expression
I've left some changes, mostly to match a better dependency declaration.
087e225
to
a2bc71f
Compare
a2bc71f
to
a0d657f
Compare
@GrahamcOfBorg build akira-unstable |
a0d657f
to
bcd76b0
Compare
Co-authored-by: worldofpeace <worldofpeace@users.noreply.github.com>
bcd76b0
to
f525735
Compare
Oh sorry, it took me a bit to get back to this. |
Thanks @filalex77 ✨ |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)This change is