Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akira-unstable: init at 2019-10-12 #74332

Merged
merged 1 commit into from Dec 3, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@jonringer
Copy link
Contributor

cc @worldofpeace for qt/gtk wrapping review :)

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
gui opens fine

[3 built, 3 copied (15.4 MiB), 2.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74332
1 package were built:
akira

@jonringer
Copy link
Contributor

@GrahamcOfBorg build akira

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please follow the code style like this expression

I've left some changes, mostly to match a better dependency declaration.

pkgs/applications/graphics/akira/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/akira/meson-post-install.patch Outdated Show resolved Hide resolved
pkgs/applications/graphics/akira/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/akira/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/akira/default.nix Show resolved Hide resolved
pkgs/applications/graphics/akira/default.nix Outdated Show resolved Hide resolved
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build akira-unstable

@Br1ght0ne Br1ght0ne changed the title akira: init at 2019-10-12 akira-unstable: init at 2019-10-12 Nov 28, 2019
Co-authored-by: worldofpeace <worldofpeace@users.noreply.github.com>
@worldofpeace
Copy link
Contributor

Oh sorry, it took me a bit to get back to this.

@worldofpeace worldofpeace merged commit ddf711c into NixOS:master Dec 3, 2019
@Br1ght0ne Br1ght0ne deleted the akira-2019-10-12 branch December 3, 2019 17:01
@worldofpeace
Copy link
Contributor

Thanks @filalex77 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants