Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg-full: enable jack #74331

Merged
merged 1 commit into from Dec 7, 2019
Merged

ffmpeg-full: enable jack #74331

merged 1 commit into from Dec 7, 2019

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Nov 27, 2019 •
edited

Motivation for this change

ffmpeg-full did not enable jack support in the build, although it included libjack in the build inputs. IMO, the full build of ffmpeg should include jack support. It's useful for recording screencasts of audio applications, for instance.

Warning - I'm not sure if this will not break on Darwin as the file contains the following note:

 * Need fixes to support Darwin:
 *   frei0r game-music-emu gsm libjack2 libmfx(intel-media-sdk) libssh
 *   libvpx(stable 1.3.0) openal openjpeg pulseaudio rtmpdump samba vid-stab
 *   wavpack x265 xavs

However, other mentioned packages are enabled in the ./configure options, so I don't see why libjack shouldn't be.

Things done

Enabled libjack in the ./configure arguments.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @codyopel @Fuuzetsu

@ofborg ofborg bot requested a review from Fuuzetsu November 27, 2019 13:24
@yurkobb
Copy link
Contributor Author

yurkobb commented Nov 27, 2019

As a side note, this package (regardless of this PR) fails to build on aarch64, but it should be fixed by this update (thanks to Jan Tojnar at #nixos:timepath.xyz matrix room for pointing this out).

@srhb
Copy link
Contributor

srhb commented Dec 7, 2019

@GrahamcOfBorg build ffmpeg-full

@yurkobb
Copy link
Contributor Author

yurkobb commented Dec 7, 2019

Yay, the arm build was fixed too, thanks to jack update.

@srhb
Copy link
Contributor

srhb commented Dec 7, 2019

What's the closure size change here? :)

@yurkobb
Copy link
Contributor Author

yurkobb commented Dec 7, 2019

What's the closure size change here? :)

I'm not sure I'm doing this correctly, but:

$ git checkout master
$ nix-build . -A ffmpeg-full
<...>
$ nix path-info -S ./result/ > before.size
$ git checkout ffmpeg-full-jack
$ nix-build . -A ffmpeg-full
<...>
$ nix path-info -S ./result/ > after.size
$ cat before.size after.size
/nix/store/c2648r8m4wjpzmcjiw9h437xmmg9xxsq-ffmpeg-full-4.2.1     509254536
/nix/store/cs0vxd2i861dc1iw0s370rgxc9sm8l3d-ffmpeg-full-4.2.1     509864336
$ echo $((509864336 - 509254536))
609800

@srhb
Copy link
Contributor

srhb commented Dec 7, 2019

You're doing it correctly and that looks very reasonable!

@srhb srhb merged commit 7e9abc8 into NixOS:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurkobb @srhb