Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tensorflow-build: enable on darwin #74334

Merged
merged 2 commits into from Dec 8, 2019
Merged

python3Packages.tensorflow-build: enable on darwin #74334

merged 2 commits into from Dec 8, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 27, 2019 •
edited

Motivation for this change

This should be a way to fix tensorflow on darwin. The tensorflow-bin is broken (#73703).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 27, 2019
@veprbl veprbl changed the title python3Packages.tensorflow: enable on darwin python3Packages.tensorflow-build: enable on darwin Nov 27, 2019
@ofborg ofborg bot requested a review from abbradar November 27, 2019 13:56
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.tensorflow

@veprbl veprbl merged commit adbd96a into NixOS:master Dec 8, 2019
@veprbl
Copy link
Member Author

veprbl commented Dec 12, 2019

Hydra doesn't seem to be able to build it:
https://hydra.nixos.org/job/nixpkgs/trunk/python37Packages.tensorflow.x86_64-darwin

I don't understand why in https://hydra.nixos.org/build/108086001 we got

Neither 'python3' nor 'python' were found on the target platform's PATH, which is:

when I can do

# nix-store -r /nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env
# ls /nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python* 
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python-config
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3-config
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3.7
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3.7-config
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3.7m
/nix/store/b2nfnj6m9m3ibbm9gwb54c39xh3x86wf-python3-3.7.5-env/bin/python3.7m-config

@veprbl veprbl deleted the pr/tensorflow_darwin_enable branch December 12, 2019 01:18
@veprbl veprbl mentioned this pull request Dec 12, 2019
Closed
@veprbl veprbl restored the pr/tensorflow_darwin_enable branch December 1, 2020 16:58
@veprbl veprbl deleted the pr/tensorflow_darwin_enable branch December 1, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @jonringer