Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.behave: use pytest_4 #74416

Merged
merged 1 commit into from Nov 28, 2019
Merged

python3Packages.behave: use pytest_4 #74416

merged 1 commit into from Nov 28, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 28, 2019 •
edited

Motivation for this change

noticed it was broken reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[0 built (1 failed)]
error: build of '/nix/store/ids4x92xnwi4031m8lkgngjqppbwwj8a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74416
2 package failed to build:
python38Packages.behave python38Packages.python-docx

2 package were built:
python37Packages.behave python37Packages.python-docx

@jonringer
Copy link
Contributor Author

they haven't had a release in 9 months, don't know when they will add support for python38

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.behave python37Packages.python-docx

@jonringer jonringer merged commit f4f8169 into NixOS:master Nov 28, 2019
@jonringer jonringer deleted the fix-behave branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer