Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WoeUSB: Remove writeback buffering workaround #70826

Merged
merged 1 commit into from Oct 11, 2019
Merged

WoeUSB: Remove writeback buffering workaround #70826

merged 1 commit into from Oct 11, 2019

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Oct 9, 2019

Motivation for this change

WoeUSB contains a writeback buffering workaround for 64-bit Linux systems, however this workaround relies on setting /proc/sys/vm/dirty_background_bytes which no longer works on newer
versions of the Linux kernel. The issue is being tracked at slacka/WoeUSB#267, this is a workaround posted in that GitHub issue thread.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor @gnidorah

@Enzime
WoeUSB: Remove writeback buffering workaround
a6c6e90 
WoeUSB contains a writeback buffering workaround for 64-bit Linux
systems, however this workaround relies on setting
/proc/sys/vm/dirty_background_bytes which no longer works on newer
versions of the Linux kernel.
@ofborg ofborg bot requested review from bjornfor and a user October 9, 2019 02:43
@bjornfor
Copy link
Contributor

bjornfor commented Oct 9, 2019

Is upstream dead? (I personally prefer this to be handled upstream.)

@Enzime
Copy link
Member Author

Enzime commented Oct 11, 2019 •
edited

Not sure if they're dead, but no activity since April. I'd suggest we should just merge this in now and we can remove the patch if upstream fixes it in a future update.

@bjornfor bjornfor merged commit 0277cc1 into NixOS:master Oct 11, 2019
@bjornfor
Copy link
Contributor

I pinged upstream.

@Enzime Enzime deleted the patch-woeusb branch October 12, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Enzime @bjornfor