Don’t use stat --printf in nix-profile.sh #3129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks on some systems where "coreutils" commands are installed in multiple places. We only needed coreutils here for the ‘stat --printf’ checks on the user ownership. This removes those checks. This check should be done in Nix commands like “nix doctor”. Fixes NixOS#3127
|
I'd like to get rid of these checks, but currently they're the only thing guarding against #509. |
|
Is there a way to get these checks without causing #3127? |
|
|
Opened #3135 as an alternative. Still not ideal, but at least will fix this particular issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks on some systems where "coreutils" commands are installed
in multiple places. We only needed coreutils here for the ‘stat
--printf’ checks on the user ownership. This removes those checks.
This check should be done in Nix commands like “nix doctor”.
Fixes #3127