Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delly: init at 0.8.1 #70871

Merged
merged 2 commits into from Oct 11, 2019
Merged

delly: init at 0.8.1 #70871

merged 2 commits into from Oct 11, 2019

Conversation

scalavision
Copy link
Contributor

Motivation for this change
Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • [ x] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.
Notify maintainers

cc @

@scalavision
Copy link
Contributor Author

Delly is a very much used tool used to find structural variants within dna sequenced, short read data. It would be very nice to have it in nixpkgs.

markuskowa
markuskowa requested changes Oct 9, 2019
View reviewed changes
pkgs/applications/science/biology/delly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/delly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/delly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/delly/default.nix Outdated Show resolved Hide resolved
@mmahut mmahut changed the title Add delly to biology pkgs delly: init at 0.8.1 Oct 10, 2019
@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

After fixing the issues above, please squash your commits too.

@scalavision
Copy link
Contributor Author

Thanks for all the nice feedback! I've removed buildPhase, only using prePhase. Also I've cleaned up the installPhase, which seems to work.

Anyone knows why the checkMeta validation doesn't work? It says something about scylla-db. I don't think I have anything related to that.

@scalavision scalavision mentioned this pull request Oct 10, 2019
Merged
5 tasks
@veprbl
fixup
898c2c8 
prePhase is not a thing
@veprbl
Copy link
Member

veprbl commented Oct 10, 2019

Eval should be fixed by c0d5833

@veprbl
Copy link
Member

veprbl commented Oct 10, 2019

@GrahamcOfBorg build delly

@veprbl veprbl merged commit 3d86097 into NixOS:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa requested changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scalavision @mmahut @veprbl @markuskowa