Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rl-1909: brief package version changes #70873

Merged
merged 1 commit into from
Oct 9, 2019
Merged

rl-1909: brief package version changes #70873

merged 1 commit into from
Oct 9, 2019
+21 −1

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Screenshot from 2019-10-09 13-46-15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2019
@worldofpeace
rl-1909: brief package version changes

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 78AC5AE55A47A65B
Verified
Learn about vigilant mode
f853bb4
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Oct 9, 2019
@jonringer
Copy link
Contributor

may want to mention that setuptools is no longer propagated by default in python packages. Reduces closure size. Not sure if it's a "core" change though

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Oct 9, 2019 •
edited
Loading

@jonringer I thought that there should be a dedicated section on language frameworks, but I think that's less nixos and more general nixpkgs. It would be a good improvement in the future though, there's soo many changes in that regard.

Edit: not that I'm suggesting we should be editing release notes post-release 😄

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 9, 2019
@worldofpeace worldofpeace merged commit b0f50ef into NixOS:master Oct 9, 2019
@worldofpeace worldofpeace deleted the rl-notes-19.09-fixup branch October 9, 2019 18:14
@worldofpeace
Copy link
Contributor Author

backported in 3fdcd76

@jonringer
Copy link
Contributor

That's fair. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@lheckemann lheckemann

@disassembler disassembler

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jonringer @grahamc