Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: 1.3.1 -> 1.3.4 #70898

Merged
merged 2 commits into from
Oct 15, 2019
Merged

next: 1.3.1 -> 1.3.4 #70898

merged 2 commits into from
Oct 15, 2019

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Oct 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added the 8.has: documentation This PR adds or changes documentation label Oct 10, 2019
nlewo added 2 commits October 10, 2019 10:08

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 10, 2019
@nlewo nlewo merged commit 6e54ef8 into NixOS:master Oct 15, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 24, 2019

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter
next: 1.3.1 -> 1.3.4
(cherry picked from commit 6e54ef8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant