Reland CompressionStream #19614
Merged
Reland CompressionStream #19614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1851584
branch
from
0fa438b
to
168c97b
Compare
Implement compression for "gzip" and "deflate". The implementation is hidden behind the ExperimentalCompressionStream flag. For unit tests, we compress and stream and uncompress it with pako, and we make sure its output is the same as our original data. The original CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1849376 due to failures on the MSAN and leak bots. The compression-stream.any.js test has been modified from the original version of this CL to improve performance, and also marked as slow. TBR=kinuko Bug: 999091 Change-Id: I3952f500cd1ea614397fdf47771e037546583a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704544}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1851584
branch
from
168c97b
to
0b45a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement compression for "gzip" and "deflate". The implementation is
hidden behind the ExperimentalCompressionStream flag.
For unit tests, we compress and stream and uncompress it with pako, and
we make sure its output is the same as our original data.
The original CL was reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1849376
due to failures on the MSAN and leak bots.
The compression-stream.any.js test has been modified from the original
version of this CL to improve performance, and also marked as slow.
TBR=kinuko
Bug: 999091
Change-Id: I3952f500cd1ea614397fdf47771e037546583a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704544}