Stop using private properties for data properties of cross-origin properties #19589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1844520
branch
8 times, most recently
from
67d7bb7
to
1bb0ee9
Compare
…perties Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty. So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter. This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties. Bug: 715418 Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706304}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1844520
branch
from
1bb0ee9
to
ee21d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty.
So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter.
This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties.
Bug: 715418
Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706304}