argo: 2.2.1 -> 2.4.1 #70672
argo: 2.2.1 -> 2.4.1 #70672
Conversation
|
@GrahamcOfBorg build argo |
1 similar comment
|
@GrahamcOfBorg build argo |
|
you need to be whitelisted for ofborg to run your commands :) |
| }; | ||
|
|
||
| goDeps = ./deps.nix; | ||
| goPackagePath = "github.com/argoproj/argo"; | ||
| subPackages = [ "cmd/argo" ]; |
There was a problem hiding this comment.
Why switch to installing only argo? What about the other two commands?
There was a problem hiding this comment.
I can keep the other 2 binaries, but they are really only useful inside a Kubernetes Operator context when the full argo system is installed on a cluster.
The argo CLI is what I think is more relevant to users. It's more like a argoctl, but such a project does not exist.
I'm happy to add back the rest of the binaries if you prefer? Or I can add them back if somebody asks for them in the community?
There was a problem hiding this comment.
I'm ok to leave them off. We can add them if someone asks for them.
There was a problem hiding this comment.
another option would be to add a argoFull where they are available. But if the closure saving is minimal I'm okay with them being added back.
|
@GrahamcOfBorg build argo |
(cherry picked from commit 5078eba)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @