Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argo: 2.2.1 -> 2.4.1 #70672

Merged
merged 1 commit into from Oct 13, 2019
Merged

argo: 2.2.1 -> 2.4.1 #70672

merged 1 commit into from Oct 13, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Oct 7, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@groodt groodt mentioned this pull request Oct 7, 2019
Closed
10 tasks
@groodt
Copy link
Contributor Author

groodt commented Oct 7, 2019

@GrahamcOfBorg build argo

1 similar comment
@jonringer
Copy link
Contributor

@GrahamcOfBorg build argo

@jonringer
Copy link
Contributor

you need to be whitelisted for ofborg to run your commands :)

jonringer
jonringer approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[63 built, 2 copied (4.8 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70672
1 package were build:
argo

cc @kalbasit for go input

kalbasit
kalbasit reviewed Oct 8, 2019
View reviewed changes
pkgs/applications/networking/cluster/argo/default.nix
};

goDeps = ./deps.nix;
goPackagePath = "github.com/argoproj/argo";
subPackages = [ "cmd/argo" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why switch to installing only argo? What about the other two commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can keep the other 2 binaries, but they are really only useful inside a Kubernetes Operator context when the full argo system is installed on a cluster.

The argo CLI is what I think is more relevant to users. It's more like a argoctl, but such a project does not exist.

I'm happy to add back the rest of the binaries if you prefer? Or I can add them back if somebody asks for them in the community?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to leave them off. We can add them if someone asks for them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option would be to add a argoFull where they are available. But if the closure saving is minimal I'm okay with them being added back.

@groodt groodt changed the title argo: 2.2.1 -> 2.4.0 argo: 2.2.1 -> 2.4.1 Oct 9, 2019
@kalbasit
Copy link
Member

kalbasit commented Oct 9, 2019

@GrahamcOfBorg build argo

@kalbasit kalbasit merged commit 5078eba into NixOS:master Oct 13, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@groodt @dtzWill
argo: 2.2.1 -> 2.4.1 (NixOS#70672)
8a024ec 
(cherry picked from commit 5078eba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@groodt @jonringer @kalbasit