Remove extra double quotes in manifest_build.py #19560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
changed the title
|
Actually I found that this could be simplified by just using %B and not trying to combine summary and summary-less body. If approved I'll squash to a more sensible commit message than is on the branch now. |
|
Given #19568 (comment) I'd like to add support from running this in dry run mode on PRs, in case it's totally broken by this. |
jgraham
approved these changes
Oct 8, 2019
|
I'll rebase this on top of #19573 when that's landed to get some confidence that it doesn't break everything. |
There's no shell escaping at this layer, so these quotes were treated as literal and included in the release body. This also simplies the code by using --format=%B.
foolip
force-pushed
the
foolip/release-quotes
branch
from
9a9064c
to
c41721e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no shell escaping at this layer, so these quotes were treated as literal
and included in the release body.
Also add an extra blank line to separate summary and body like in commit messages.