Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware-linux-nonfree: 2019-08-15 -> 2019-09-23 #70817

Merged
merged 1 commit into from
Oct 10, 2019
Merged

firmware-linux-nonfree: 2019-08-15 -> 2019-09-23 #70817

merged 1 commit into from
Oct 10, 2019
+4 −4

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Oct 9, 2019

Motivation for this change

Firmware necessary for Navi10 #68809

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

Sorry, something went wrong.

@ofborg ofborg bot requested a review from fpletz October 9, 2019 01:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 9, 2019
@Enzime
firmware-linux-nonfree: 2019-08-15 -> 2019-09-23

Verified

This commit was signed with the committer’s verified signature.
shuding Shu Ding
GPG key ID: 899520937F032E83
Verified
Learn about vigilant mode
bb978d8
@Enzime Enzime force-pushed the update-nonfree-firmware branch from 7bb1fa9 to bb978d8 Compare October 9, 2019 02:01
jb55
jb55 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fpletz
Copy link
Member

fpletz commented Oct 10, 2019

@GrahamcOfBorg build firmwareLinuxNonfree

@fpletz fpletz merged commit f01ad3e into NixOS:master Oct 10, 2019
@Enzime Enzime deleted the update-nonfree-firmware branch October 11, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55

@fpletz fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @fpletz @jb55