Test removing a box before a self-collapsing block with clearance. #19564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845759
branch
from
92bde2c
to
b52a13c
Compare
This broke for M77 and got fixed again after the branch point. Looks like we had no test coverage for it, but it affected WhatsApp for web. A phantom line [1] was also required to reproduce the bug. [1] https://www.w3.org/TR/CSS22/visuren.html#phantom-line-box Bug: 1003810 Change-Id: I942aea83bbf71a247cf73332dcf62af7c9343106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845759 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703899}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845759
branch
from
b52a13c
to
7c4b577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke for M77 and got fixed again after the branch point. Looks
like we had no test coverage for it, but it affected WhatsApp for web.
A phantom line [1] was also required to reproduce the bug.
[1] https://www.w3.org/TR/CSS22/visuren.html#phantom-line-box
Bug: 1003810
Change-Id: I942aea83bbf71a247cf73332dcf62af7c9343106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845759
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703899}