-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python.pkgs.google_cloud_storage: propagate setuptools #70900
Conversation
@flokli Whatever depends on |
This is used during runtime. cc NixOS#68314
04f48c9
to
789565d
Compare
hrm, it's not really inspectable. @FRidh I wonder if we could add some script in fixup phase warning/failing on non-progated setuptools, but code like But out of the scope for this PR. I looked at the python google package dependencies of |
We could create a hook that greps on |
@FRidh Thinking the same. Should be good and we could probably get them all in one go. |
It's a pity there are so more many packages that use Next couple of days I'll be occupied with #71222. After that, could run a run with the proposed hook. |
This is used during runtime.
cc #68314
Motivation for this change
python.pkgs.google_cloud_storage
requires setuptools at runtime.This looks like a pattern used in other parts of the google bindings aswell, so we might want to fix those too / cc @costrouc.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @costrouc