Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CompressionStream" #19592

Merged
merged 1 commit into from Oct 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 9, 2019

This reverts commit 6e443093073dcea5c3ee85257f82e7c4433198f3.

Reason for revert: Causes failures on WebKit Linux Leaks and Webkit Linux MSAN, see https://crbug.com/1012652

Original change's description:

CompressionStream

Implement compression for "gzip" and "deflate". That implementation is
hidden behing ExperimentalCompressionStream flag.

For unit tests, we compress and stream and uncompress it with pako, and
we make sure its output is the same as our original data.

Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704009}

Bug: 1012652
TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,robertma@chromium.org,acomminos@fb.com,arenevier@fb.com

Change-Id: I3d57975faa0206478048f518b53dcb617192b016
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849376
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704123}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

This reverts commit 6e443093073dcea5c3ee85257f82e7c4433198f3.

Reason for revert: Causes failures on WebKit Linux Leaks and Webkit Linux MSAN, see https://crbug.com/1012652

Original change's description:
> CompressionStream
>
> Implement compression for "gzip" and "deflate". That implementation is
> hidden behing ExperimentalCompressionStream flag.
>
> For unit tests, we compress and stream and uncompress it with pako, and
> we make sure its output is the same as our original data.
>
> Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#704009}

Bug: 1012652
TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,robertma@chromium.org,acomminos@fb.com,arenevier@fb.com

Change-Id: I3d57975faa0206478048f518b53dcb617192b016
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849376
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704123}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants